On 9/6/2018 4:18 PM, James Darnley wrote:
> On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote:
>> + if (s->metadata_header_padding) {
>> + if (s->metadata_header_padding == 1)
>> + s->metadata_header_padding++;
>> + put_ebml_void(pb, s->metadata_header_padding);
>> + }
>
> Unfortunately I was forced to make the default -1 so you want to check
> that the value is greater than 0 rather than just true.
>
> Furthermore I think you will still want to add to Changelog making a
> note that the matroska muxer will now listen to metadata_header_padding.
No, this kind of change doesn't justify a Changelog entry as mentioned
before.
> That may also want a micro version bump so that library users can check.
Micro version bump is ok.
>
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
