On Fri, Aug 17, 2018 at 12:50 AM <[email protected]> wrote: > > > > On 16 Aug 2018, at 17:43, Thilo Borgmann <[email protected]> wrote: > > > > Hi, > > > >> --- /Users/mark/Downloads/udpORIG.c 2018-08-16 15:39:21.000000000 +0100 > >> +++ /Users/mark/Downloads/udp.c 2018-08-16 15:40:55.000000000 +0100 > >> @@ -828,7 +828,11 @@ > >> s->reuse_socket = 1; > >> if (setsockopt (udp_fd, SOL_SOCKET, SO_REUSEADDR, > >> &(s->reuse_socket), sizeof(s->reuse_socket)) != 0) > >> goto fail; > >> - } > >> + #ifdef __APPLE__ // MacOS/X requires an additional call > >> + if (setsockopt (udp_fd, SOL_SOCKET, SO_REUSEPORT, > >> &(s->reuse_socket), sizeof(s->reuse_socket)) != 0) > >> + goto fail; > >> + #endif > >> + } > >> > >> if (s->is_broadcast) { > >> #ifdef SO_BROADCAST > > > > Not sure but that might also affect other BSD derivatives like Gentoo... > > can you test on Linux and some BSD also? > > (I've got no other BSD kind of OS other than OSX) f > > Its certainly NOT an issue on Ubuntu Linux. > > I don't have any other BSD variants to test with either, sorry. > This is a fairly well documented quirk of macOS, however. > > Can you use a new option for SO_REUSEPORT, as my point: 1). An option more flexible than a hard code. 2). As I know, Linux (Kernel > 3.9) has support SO_REUSEPORT, and maybe we will add this function in Linux (https://lwn.net/Articles/542629/ 3). Do you plan enable this function for TCP?
Thanks. _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
