On 25-06-2018 06:39 AM, Michael Niedermayer wrote:
arguments types are wrong
}
+
timestamp = (o->start_time == AV_NOPTS_VALUE) ? 0 : o->start_time;
unrelated, this should not be in this patch
Revised. Will push soon.
Thanks,
Gyan
From ca9d51bca4cb303897bf32ff3900fa36f3cf7074 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <[email protected]>
Date: Fri, 22 Jun 2018 22:02:16 +0530
Subject: [PATCH v2] fftools/ffmpeg: check sseof value and clash with ss
Prioritize -ss
---
fftools/ffmpeg_opt.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index a2ecddae71..58ec13e5a8 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -1103,9 +1103,22 @@ static int open_input_file(OptionsContext *o, const char
*filename)
}
}
+ if (o->start_time != AV_NOPTS_VALUE && o->start_time_eof !=
AV_NOPTS_VALUE) {
+ av_log(NULL, AV_LOG_WARNING, "Cannot use -ss and -sseof both, using
-ss for %s\n", filename);
+ o->start_time_eof = AV_NOPTS_VALUE;
+ }
+
if (o->start_time_eof != AV_NOPTS_VALUE) {
- if (ic->duration>0) {
+ if (o->start_time_eof >= 0) {
+ av_log(NULL, AV_LOG_ERROR, "-sseof value must be negative;
aborting\n");
+ exit_program(1);
+ }
+ if (ic->duration > 0) {
o->start_time = o->start_time_eof + ic->duration;
+ if (o->start_time < 0) {
+ av_log(NULL, AV_LOG_WARNING, "-sseof value seeks to before
start of file %s; ignored\n", filename);
+ o->start_time = AV_NOPTS_VALUE;
+ }
} else
av_log(NULL, AV_LOG_WARNING, "Cannot use -sseof, duration of %s
not known\n", filename);
}
--
2.12.2.windows.2_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
