On Mon, Jan 08, 2018 at 20:16:48 -0500, Devin Heitmueller wrote:
> + if (ctx->supports_vanc == 0 ||
> ctx->dlo->DoesSupportVideoMode(ctx->bmd_mode, ctx->raw_format,
In other places you (or the DeckLink code) use
if (!ctx->supports_vanc || [...]
which I believe is preferred.
> + if (ctx->supports_vanc == 0)
Same here.
> + if (ret != 0)
> + return AVERROR(ENOMEM);
Same here.
> + ret = klvanc_set_framerate_EIA_708B(pkt, ctx->bmd_tb_num,
> ctx->bmd_tb_den);
> + if (ret != 0) {
> + av_log(avctx, AV_LOG_ERROR, "Invalid framerate specified:
> %lld/%lld\n",
Same here, and others.
> + for (size_t i = 0; i < cc_count; i++) {
Declare i outside the clause.
> + for (int i = 0; i < vanc_lines.num_lines; i++) {
Same here.
> + if (line == NULL)
if (!line)
These comments apply to several of the other patches as well.
Moritz
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
