2018-01-07 15:40 GMT+01:00 Jörn Heusipp <[email protected]>: > > On 01/06/2018 04:06 PM, Carl Eugen Hoyos wrote: >> >> 2018-01-06 11:07 GMT+01:00 Jörn Heusipp >> <[email protected]>:
>>> - .extensions = >>> "669,amf,ams,dbm,digi,dmf,dsm,far,gdm,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,stk,stm,ult,umx,wow,xm,xpk", >>> +#if OPENMPT_API_VERSION_AT_LEAST(0,3,0) >>> + .extensions = >>> "669,amf,ams,dbm,digi,dmf,dsm,dtm,far,gdm,ice,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,st26,stk,stm,stp,ult,umx,wow,xm,xpk", >>> +#else >>> + .extensions = >>> "669,amf,ams,dbm,digi,dmf,dsm,far,gdm,ice,imf,it,j2b,m15,mdl,med,mmcmp,mms,mo3,mod,mptm,mt2,mtm,nst,okt,plm,ppm,psm,pt36,ptm,s3m,sfx,sfx2,st26,stk,stm,ult,umx,wow,xm,xpk", >>> +#endif >> >> >> I believe this change can be made without the version check. > > Why would that be better? Only because of the simplification: Other parts of FFmpeg will not support the files anyway, and I am sure we can find a real-world files that have one of above extensions but are not supported by libopenmpt (because they are completely different files). Can't libopenmpt be configured to support only some of above file types? But feel free to ignore my suggestion. Carl Eugen _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
