On 29/11/17 12:22, Moritz Barsnick wrote:
> On Wed, Nov 29, 2017 at 00:34:03 +0000, Mark Thompson wrote:
>> + if (type == AV_HWDEVICE_TYPE_NONE) {
>> + fprintf(stderr, "Device type %s is not supported.\n", argv[1]);
>> + fprintf(stderr, "Available device types:");
>> + type = AV_HWDEVICE_TYPE_NONE;
>> + while((type = av_hwdevice_iterate_types(type)) !=
>> AV_HWDEVICE_TYPE_NONE)
>> + fprintf(stderr, " %s", av_hwdevice_get_type_name(type));
>
> I see what you're trying to do with "type = AV_HWDEVICE_TYPE_NONE"
> (initialize the iterator), but the assignment is redundant.
>
> I guess if the compiler optimizes it away anyway, it may be good for
> readability, especially since it's an example. *shrug*
Huh, I didn't notice that.
I've removed it - the iterating over devices is just to make the error message
nicer and mostly irrelevant for the example, so I think avoiding the redundancy
wins.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
