2017-11-15 22:00 GMT+01:00 Colin NG <[email protected]>:
> This patch is partial fix for ticket 6658 (Dash demuxer segfault).
> +static struct fragment * get_Fragment(char *range) {
> + struct fragment * seg = av_mallocz(sizeof(struct fragment));
Please make it (code-style):
... fragment *get_Fragment...
... fragment *seg =...
> + if (!seg)
> + goto finish;
No.
You can "return NULL;" but since this is a little misleading,
it may be better to return AVERROR(ENOMEM) and instead
of the existing check for NULL below, check for "< 0".
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
