On Sun, Sep 10, 2017 at 10:28:05PM +0200, Tomas Härdin wrote:
> On Sun, 2017-09-10 at 22:10 +0200, Michael Niedermayer wrote:
> > enum {
> > INDEX_MPEG2 = 0,
> > INDEX_AES3,
> > @@ -159,6 +139,26 @@ enum {
> > INDEX_H264,
> > };
> >
> > +static const struct {
> > + enum AVCodecID id;
> > + int index;
> > +} mxf_essence_mappings[] = {
> > + { AV_CODEC_ID_MPEG2VIDEO, INDEX_MPEG2 },
> > + { AV_CODEC_ID_PCM_S24LE, INDEX_AES3 },
> > + { AV_CODEC_ID_PCM_S16LE, INDEX_AES3 },
> > + { AV_CODEC_ID_DVVIDEO, INDEX_DV },
> > + { AV_CODEC_ID_DNXHD, INDEX_DNXHD_1080p_10bit_HIGH },
> > + { AV_CODEC_ID_JPEG2000, INDEX_JPEG2000 },
> > + { AV_CODEC_ID_H264, INDEX_H264 },
> > + { AV_CODEC_ID_NONE }
> > +};
>
> This is tangentally relevant perhaps, but that INDEX_ enum should
> really be type. Something like ULIndex and a comment with reference to
> relevant spec section would be niceAbout referencing a spec. The index is never written its just used in our implementation as a way to keep track of the "type" we deal with so these can actually be reordered / tere values changed with no change to any output case as long as all tables which imply this order are also updated. So i dont think theres a spec that can be referenced [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger. -- Epictetus
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
