On 2017-03-21 13:16, Steven Liu wrote:
> @@ -5920,6 +5923,7 @@ enabled openssl && { use_pkg_config openssl
> openssl/ssl.h OPENSSL_init
> check_lib openssl/ssl.h SSL_library_init
> -lssl -lcrypto -lws2_32 -lgdi32 ||
> die "ERROR: openssl not found"; }
> enabled qtkit_indev && { check_header_objcc QTKit/QTKit.h || disable
> qtkit_indev; }
> +enabled libxml2 && require_pkg_config libxml-2.0
> libxml2/libxml/xmlversion.h xmlCheckVersion -lxml2
When you use require_pkg_config you don't need to add -lxml2 at the end, it'll
get the needed libs and cflags from the pkgconfig file.
Also, there's no need to send a new patch/thread for every small change. This
is a large patch which will probably need a lot of reviewing before it's
merged. At this pace there'll be 30 versions before long. An aknowledgement
that the review is considered and that a later patch will address it should be
enough, IMHO.
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
