On Sun, 1 Jan 2017, Steven Liu wrote:



2017-01-01 21:22 GMT+08:00 Steven Liu <[email protected]>:


      2017-01-01 21:01 GMT+08:00 Marton Balint <[email protected]>:

            On Sun, 1 Jan 2017, Steven Liu wrote:


                  applied!


            Steven, any reason you are overriding the "committer" field? I 
think what people typically do when pushing patches is that they only keep the authorship 
of the original owner, and the
            comitter remains the person who actually pushes the patch, in your 
case it should be you :).


Marton,

Author: Bela Bodecs <[email protected]>
Signed-off-by: Bela Bodecs <[email protected]>

Patch be merged by Steven Liu, and Committer is Steven Liu
Any problem or any rules? 

http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=03a69bd897e49a636a7c2f044f74fb96288955d4

Author and Committer is both Bela Bodecs. The comitter is supposed to be you IMHO.

commit 03a69bd897e49a636a7c2f044f74fb96288955d4
Author: Bela Bodecs <[email protected]>
Date:   Sun Jan 1 20:22:34 2017 +0800

    avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir
    
    Current implementation of finding duplicate segment filenames may fail
    if use_localtime_mkdir and use_localtime are in effect and
    segment_filename option expression contains subdirectories with
    date/time specifiers. This patch fixes this false behaviour.
    
    Signed-off-by: Bela Bodecs <[email protected]>
    Signed-off-by: Steven Liu <[email protected]>


git log --pretty=full shows the committer as well, and not just the author:

commit 03a69bd897e49a636a7c2f044f74fb96288955d4
Author: Bela Bodecs <[email protected]>
Commit: Bela Bodecs <[email protected]>

    avformat/hlsenc: Duplicated segment filenames and use_localtime_mkdir

    Current implementation of finding duplicate segment filenames may fail
    if use_localtime_mkdir and use_localtime are in effect and
    segment_filename option expression contains subdirectories with
    date/time specifiers. This patch fixes this false behaviour.

    Signed-off-by: Bela Bodecs <[email protected]>
    Signed-off-by: Steven Liu <[email protected]>


Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to