Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: >> On Mon, 17 Oct 2016 13:09:36 +0200 >> Michael Niedermayer <[email protected]> wrote: >> >>> On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: >>>> Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : >>>>> probably, yes >>>> >>>> I would have said exactly the opposite. It is nothing but a waste of time >>>> and a pollution of the history. >>> >>> My idea here is to maximize the number of developers >>> And if in cases where one doesnt really care much either way and >>> someone else seems caring more one says, "ok" that may result in a happy >>> new contributor. >>> Saying "no" is more likely to turn someone away. >>> and again, it doesnt really matter if the , is there after a >>> final sentinel /count entry as no next field would ever be added >> >> Are you kidding me. Patches should be judged on their technical merrit, >> not whether you might piss someone off by rejecting it. > > this is about a cosmetic change having no real technical effect
So here are my cosmetics for libavutil. It simply helps with keeping track of real warnings in downstream projects. Best regards, Michael
diff -rup FFmpeg-master/libavutil/log.h FFmpeg/libavutil/log.h
--- FFmpeg-master/libavutil/log.h 2016-10-17 19:47:57.000000000 +0200
+++ FFmpeg/libavutil/log.h 2016-10-17 20:30:38.545498875 +0200
@@ -44,7 +44,7 @@ typedef enum {
AV_CLASS_CATEGORY_DEVICE_AUDIO_INPUT,
AV_CLASS_CATEGORY_DEVICE_OUTPUT,
AV_CLASS_CATEGORY_DEVICE_INPUT,
- AV_CLASS_CATEGORY_NB, ///< not part of ABI/API
+ AV_CLASS_CATEGORY_NB ///< not part of ABI/API
}AVClassCategory;
#define AV_IS_INPUT_DEVICE(category) \
diff -rup FFmpeg-master/libavutil/pixfmt.h FFmpeg/libavutil/pixfmt.h
--- FFmpeg-master/libavutil/pixfmt.h 2016-10-17 19:47:57.000000000 +0200
+++ FFmpeg/libavutil/pixfmt.h 2016-10-17 20:30:38.565499123 +0200
@@ -306,7 +306,7 @@ enum AVPixelFormat {
AV_PIX_FMT_MEDIACODEC, ///< hardware decoding through MediaCodec
- AV_PIX_FMT_NB, ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions
+ AV_PIX_FMT_NB ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions
};
#if AV_HAVE_BIGENDIAN
@@ -401,7 +401,7 @@ enum AVColorPrimaries {
AVCOL_PRI_SMPTEST428_1 = 10, ///< SMPTE ST 428-1 (CIE 1931 XYZ)
AVCOL_PRI_SMPTE431 = 11, ///< SMPTE ST 431-2 (2011)
AVCOL_PRI_SMPTE432 = 12, ///< SMPTE ST 432-1 D65 (2010)
- AVCOL_PRI_NB, ///< Not part of ABI
+ AVCOL_PRI_NB ///< Not part of ABI
};
/**
@@ -427,7 +427,7 @@ enum AVColorTransferCharacteristic {
AVCOL_TRC_SMPTEST2084 = 16, ///< SMPTE ST 2084 for 10-, 12-, 14- and 16-bit systems
AVCOL_TRC_SMPTEST428_1 = 17, ///< SMPTE ST 428-1
AVCOL_TRC_ARIB_STD_B67 = 18, ///< ARIB STD-B67, known as "Hybrid log-gamma"
- AVCOL_TRC_NB, ///< Not part of ABI
+ AVCOL_TRC_NB ///< Not part of ABI
};
/**
@@ -446,7 +446,7 @@ enum AVColorSpace {
AVCOL_SPC_BT2020_NCL = 9, ///< ITU-R BT2020 non-constant luminance system
AVCOL_SPC_BT2020_CL = 10, ///< ITU-R BT2020 constant luminance system
AVCOL_SPC_SMPTE2085 = 11, ///< SMPTE 2085, Y'D'zD'x
- AVCOL_SPC_NB, ///< Not part of ABI
+ AVCOL_SPC_NB ///< Not part of ABI
};
#define AVCOL_SPC_YCGCO AVCOL_SPC_YCOCG
@@ -458,7 +458,7 @@ enum AVColorRange {
AVCOL_RANGE_UNSPECIFIED = 0,
AVCOL_RANGE_MPEG = 1, ///< the normal 219*2^(n-8) "MPEG" YUV ranges
AVCOL_RANGE_JPEG = 2, ///< the normal 2^n-1 "JPEG" YUV ranges
- AVCOL_RANGE_NB, ///< Not part of ABI
+ AVCOL_RANGE_NB ///< Not part of ABI
};
/**
@@ -484,7 +484,7 @@ enum AVChromaLocation {
AVCHROMA_LOC_TOP = 4,
AVCHROMA_LOC_BOTTOMLEFT = 5,
AVCHROMA_LOC_BOTTOM = 6,
- AVCHROMA_LOC_NB, ///< Not part of ABI
+ AVCHROMA_LOC_NB ///< Not part of ABI
};
#endif /* AVUTIL_PIXFMT_H */
signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
