On Mon, Oct 10, 2016 at 09:13:02AM +0200, Hendrik Leppkes wrote: > On Mon, Oct 10, 2016 at 9:05 AM, zzj <[email protected]> wrote: > > Signed-off-by: zzj <[email protected]> > > --- > > libavformat/utils.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/utils.c b/libavformat/utils.c > > index 5be1e86..c7d6a41 100644 > > --- a/libavformat/utils.c > > +++ b/libavformat/utils.c > > @@ -2776,7 +2776,7 @@ static void estimate_timings(AVFormatContext *ic, > > int64_t old_offset) > > * the components */ > > fill_all_stream_timings(ic); > > ic->duration_estimation_method = AVFMT_DURATION_FROM_STREAM; > > - } else { > > + } else if (strcmp(ic->iformat->name, "hls,applehttp")) { > > /* less precise: use bitrate info */ > > estimate_timings_from_bit_rate(ic); > > ic->duration_estimation_method = AVFMT_DURATION_FROM_BITRATE; >
> format name comparisons in generic code should really be avoided, if > at all possible. not arguing in favor of the specific patch but name comparisons are how the iformat is compared currently. A discussion to change this in a seperate thread here on ffmpeg-devel would be a good idea i think but This isnt a problem of this specific patch [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
