On 8/28/2016 7:48 AM, Umair Khan wrote: > On Sun, Aug 28, 2016 at 1:56 PM, Paul B Mahol <[email protected]> wrote: >> Hi, >> >> On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan <[email protected]> wrote: >> >>> Hi, >>> >>> Patches attached. :) >> >> >> Inline asm is unacceptable to get into master. > > How should that case be handled then?
As Hendrik said, it should be written in nasm/yasm. In any case, assembly optimizations should be committed as a separate patch. It will make it easier to differentiate between bugs in the c code and the handwritten assembly. Also, the changelog entry line can be part of the encoder patch, no need to have it separate. _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
