On Wed, Jun 15, 2016 at 3:25 AM, KongQun Yang <[email protected]> wrote: > -- KongQun Yang (KQ) > > On Tue, Jun 14, 2016 at 4:20 PM, Ronald S. Bultje <[email protected]> > wrote: > >> Hi, >> >> On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang <[email protected]> >> wrote: >> >>> + default: >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported color space (%d)\n", >>> + color_space); >>> + return -1; >>> >> [..] >> >>> + default: >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported pixel format (%d)\n", >>> + pixel_format); >>> + return -1; >>> >> [..] >> >>> + if (desc == NULL) { >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported pixel format (%d)\n", >>> + pixel_format); >>> + return -1; >>> >> >> You're still logging without a context (first argument), can you please >> provide one so people know which muxer is complaining about these error >> messages? >> > > Are you ok with using "AVIOContext" as the context? >
Thats an odd choice for logging. If there is no natural logging context, you should just add a "void* logctx" argument to the new function you introduced, its what is commonly done in other places. That way the mov muxer can then pass a reference to the AVFormatContext in there for more natural logging. - Hendrik _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
