> On Mar 19, 2016, at 12:34, Thilo Borgmann <[email protected]> wrote:
>
> Am 01.03.16 um 10:49 schrieb Rodger Combs:
>> [...]
>> External library support:
>> + --disable-audiotoolbox enable AudioToolbox decoders and encoders
>> [autodetect]
>
> Do we consider platform codecs external libraries?
AFAIK, we don't really have any other cases like this right now that aren't
hardware-based, but this doesn't quite fit with that group (though on iOS this
actually does support hardware AAC). I'm treating it like hwaccels in that it's
autodetected instead of explicitly enabled, and I think that makes sense, since
there's not really any difference between this and e.g. videotoolboxenc from
lavc's perspective.
>
>
>> [...]
>> + ret = AudioConverterFillComplexBuffer(at->converter,
>> ffat_decode_callback, avctx,
>> + &frame->nb_samples, &out_buffers,
>> NULL);
>> + if ((!ret || ret == 1) && frame->nb_samples) {
>> + *got_frame_ptr = 1;
>> + if (at->last_pts != AV_NOPTS_VALUE) {
>> + frame->pts = at->last_pts;
>> + at->last_pts = avpkt->pts;
>> + }
>> + } else if (ret && ret != 1) {
>
>> + av_log(avctx, AV_LOG_WARNING, "Decode error: %i\n", ret);
>
> Something useful should be printed here and for all other warnings/errors.
> This should be changed for the encoders patch as well.
>
> LGTM Otherwise.
>
> -Thilo
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
