On 02/28/2016 01:11 PM, Reimar Döffinger wrote:
On Sun, Feb 28, 2016 at 12:53:18PM +0100, Mats Peterson wrote:
- avist->pal_offset = avio_tell(pb) + 40;
+ if (pb->seekable)
+ avist->pal_offset = avio_tell(pb) + 40;
I don't mind, but the check seems unnecessary here?
Well, avio_tell() (at least ftell()) will fail on an unseekable stream.
I just checked with a small snippet. It doesn't hurt to have it, anyway.
Hm, why the cast? That seems to be the return type of that function
already...
I believe I at least have no further comments.
_______________________________________________
Yes, I suppose it's unnecessary. I actually thought of removing it
before, so I will do it now.
> I believe I at least have no further comments.
> _______________________________________________
OK. Thanks.
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
