On Sat, Jan 23, 2016 at 9:57 PM, Hendrik Leppkes <[email protected]> wrote: > On Sat, Jan 23, 2016 at 5:24 PM, Michael Niedermayer > <[email protected]> wrote: >> On Sat, Jan 23, 2016 at 05:16:28PM +0100, Hendrik Leppkes wrote: >>> On Sat, Jan 23, 2016 at 4:27 PM, Andreas Cadhalpun >>> <[email protected]> wrote: >>> > On 23.01.2016 15:07, Hendrik Leppkes wrote: >>> >> On Sat, Jan 23, 2016 at 2:51 PM, Andreas Cadhalpun >>> >> <[email protected]> wrote: >>> >>> On 23.01.2016 14:48, Hendrik Leppkes wrote: >>> >>>> Unfortunately, cygpath is not guaranteed to be available, and in fact >>> >>>> is not on some working build setups today (ie. msys1 environments with >>> >>>> msvc) >>> >>> >>> >>> Is there another way to get the Windows path on those environments? >>> >>> >>> >> >>> >> Not that I am aware. >>> > >>> > Hmm, sed should be available everywhere. >>> > >>> > Does the attached patch fix the MSVC builds? >>> > >>> >>> Unfortunately these assumptions are also not valid. On cygwin for >>> example, a path would be /cygdrive/C/path/to/folder >>> Dealing with absolute paths in the unix/windows mixture is just not >>> going to be easy, which is why we were careful to avoid them at all >>> before. >> >> IIUC windows excutables get their command line arguments translated >> from unix to dos paths. Cant that be used to turn a unix into a dos >> path to then later use in a more convoluted (not auto translated) >> argument ? >> > > We had an external wrapper before, but we just got rid of it some time > ago by fixing some more things, I would rather not get it back for > some complicated build change I don't even quite understand or see the > benefit of.
Just throwing an idea: does there exist some Makefile magic (via a shell invocation) that effectively places Andreas's original patch under an ifndef Windows? > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
