On Tue, Jan 05, 2016 at 21:19:12 +0100, Paul B Mahol wrote:
> +It accepts the following values:
> +@table @samp
> +@item replace
> +logarithmic
^^^ This description is a copy/paste error.
> +@item pheight
> +Set histogram percentage of window height.
[...]
> + { "pheight", "set histogram percentage of window height",
> OFFSET(phisto), AV_OPT_TYPE_FLOAT, {.dbl=0.10}, 0, 1, FLAGS },
This is not the first of your filters where you describe a parameter as
a "percentage", but expect a float value [0, 1]. That is extremely
confusing, if not even wrong. To me, a percentage covers [0, 100]. You
need to find a different term for the "factor" ranging from zero to
one.
I left the rest of the code functionally unreviewed so far. I will test
later.
Moritz
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
