On Tue, Sep 15, 2015 at 8:48 PM, Ronald S. Bultje <[email protected]>
wrote: \
> + if (op == 1) { \
> + for (k = 0; k < DST_BUF_SIZE; k += 4) { \
> + uint32_t r = rnd() & mask; \
> + AV_WN32A(dst0 + k, r); \
> + AV_WN32A(dst1 + k, r); \
> + } \
> + } \
I'd probably just write those unconditionally. It's simpler and avoids
potentially reading uninitialized data in failure cases.
> +static void checkasm_check_vp9mc(void)
No need for the checkasm prefix in static functions.
> + static const char *filter_names[4] = {
> + "8tap_smooth", "8tap_regular", "8tap_sharp", "bilin"
> + };
> + static const char *subpel_names[2][2] = { { "", "h" }, { "v", "hv" } };
> + static const char *op_names[2] = { "put", "avg" };
Nit++: const char * const
Otherwise LGTM.
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
