PR #23685 opened by Hunter Kvalevog (kvog) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23685 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23685.patch
# Summary of changes `SDL_AUDIO_ALSA_SET_BUFFER_SIZE` was removed in [SDL commit c591429](https://github.com/libsdl-org/SDL/commit/c591429542f429aac4979fb6ae9bbe024491a1f), released as SDL 2.0.9 on October 30, 2018. Even Ubuntu 22.04 provides SDL 2.0.20, so it should be safe to drop by now. >From fc72d0876f6f51beab7d7e2075345a1cd0397cbc Mon Sep 17 00:00:00 2001 From: Hunter Kvalevog <[email protected]> Date: Thu, 2 Jul 2026 19:17:30 -0500 Subject: [PATCH] fftools/ffplay: remove SDL_AUDIO_ALSA_SET_BUFFER_SIZE SDL_AUDIO_ALSA_SET_BUFFER_SIZE was removed in SDL 2.0.9: https://github.com/libsdl-org/SDL/commit/c591429542f429aac4979fb6ae9bbe024491a1f Signed-off-by: Hunter Kvalevog <[email protected]> --- fftools/ffplay.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 28a83e079f..93eff33b0a 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -3883,12 +3883,6 @@ int main(int argc, char **argv) flags = SDL_INIT_VIDEO | SDL_INIT_AUDIO | SDL_INIT_TIMER; if (audio_disable) flags &= ~SDL_INIT_AUDIO; - else { - /* Try to work around an occasional ALSA buffer underflow issue when the - * period size is NPOT due to ALSA resampling by forcing the buffer size. */ - if (!SDL_getenv("SDL_AUDIO_ALSA_SET_BUFFER_SIZE")) - SDL_setenv("SDL_AUDIO_ALSA_SET_BUFFER_SIZE","1", 1); - } if (display_disable) flags &= ~SDL_INIT_VIDEO; if (SDL_Init (flags)) { -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
