PR #22323 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22323 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22323.patch
Now WHIP can directly pass SSRC as UINT32 instead of converting it as INT for match wrong rtpenc option range Since 69568479a9. And Converting SSRC from UINT32 to INT64 is safe to pass by av_dict_set_int(). Signed-off-by: Jack Lau <[email protected]> >From 419818788c3739684c32731d301b16cf439c534e Mon Sep 17 00:00:00 2001 From: Jack Lau <[email protected]> Date: Sat, 28 Feb 2026 09:35:44 +0800 Subject: [PATCH] avformat/whip: use av_dict_set_int() for payload_type and ssrc Now WHIP can directly pass SSRC as UINT32 instead of converting it as INT for match wrong rtpenc option range Since 69568479a9. And Converting SSRC from UINT32 to INT64 is safe to pass by av_dict_set_int(). Signed-off-by: Jack Lau <[email protected]> --- libavformat/whip.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index bad0f38a26..aeb2c186aa 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1601,7 +1601,6 @@ static int create_rtp_muxer(AVFormatContext *s) AVFormatContext *rtp_ctx = NULL; AVDictionary *opts = NULL; uint8_t *buffer = NULL; - char buf[64]; WHIPContext *whip = s->priv_data; whip->udp->flags |= AVIO_FLAG_NONBLOCK; @@ -1663,10 +1662,8 @@ static int create_rtp_muxer(AVFormatContext *s) rtp_ctx->pb->av_class = &ff_avio_class; is_video = s->streams[i]->codecpar->codec_type == AVMEDIA_TYPE_VIDEO; - snprintf(buf, sizeof(buf), "%d", is_video? whip->video_payload_type : whip->audio_payload_type); - av_dict_set(&opts, "payload_type", buf, 0); - snprintf(buf, sizeof(buf), "%d", is_video? whip->video_ssrc : whip->audio_ssrc); - av_dict_set(&opts, "ssrc", buf, 0); + av_dict_set_int(&opts, "payload_type", is_video ? whip->video_payload_type : whip->audio_payload_type, 0); + av_dict_set_int(&opts, "ssrc", is_video ? whip->video_ssrc : whip->audio_ssrc, 0); av_dict_set_int(&opts, "seq", is_video ? whip->video_first_seq : whip->audio_first_seq, 0); ret = avformat_write_header(rtp_ctx, &opts); -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
