> configure already deps the rtp_muxer via whip_muxer_select, so it should never hit this error.
> So maybe use av_unreachable() to replace current error handling? That makes sense. Since configure already enforces the RTP dependency via whip_muxer_select, this code path should indeed be unreachable at runtime. I have updated the code to replace the current error handling with av_unreachable() accordingly, and will send an updated patch reflecting this change. Regards, Devraj On Sat, Jan 24, 2026 at 9:04 PM Devraj Ajmera <[email protected]> wrote: > Hi Jack, > > > configure already deps the rtp_muxer via whip_muxer_select, so it should > never hit this error. > > So maybe use av_unreachable() to replace current error handling? > > That makes sense. If configure already enforces the RTP dependency via > whip_muxer_select, then this code path should indeed be unreachable. > > Using av_unreachable() here sounds reasonable. I will prepare an updated > patch replacing the current error handling accordingly. > > Noted. > > Regards, > Devraj > > On Fri, Jan 23, 2026 at 12:01 PM Devraj Ajmera <[email protected]> > wrote: > >> Hi Timo, >> >> Thanks for the insightful comment. >> >> You are right that if WHIP hard-depends on RTP, this might be better >> handled at configure time rather than at runtime. The intent of this >> patch was limited to improving the clarity of the existing error path, >> without changing behavior. >> >> I agree this deserves a closer look. Would you prefer addressing this >> by tightening the configure dependencies for the WHIP muxer, or by >> adjusting the error handling (e.g. AVERROR_BUG) in this code path? >> >> Thanks, >> Devraj >> >> On Fri, Jan 23, 2026 at 11:42 AM Devraj Ajmera <[email protected]> >> wrote: >> >>> Hi Jack, >>> >>> Thanks for the review. >>> >>> You are right, the "WHIP:" prefix is unnecessary since av_log already >>> has context. >>> I have updated the patch accordingly and sent a revised version. >>> >>> Regards, >>> Devraj Ajmera >>> >>> On Tue, Jan 20, 2026 at 5:15 PM Devraj Ajmera <[email protected]> >>> wrote: >>> >>>> Hello, >>>> >>>> This patch improves the error message shown when the RTP muxer >>>> cannot be guessed in the WHIP muxer, making the failure reason >>>> clearer to users. >>>> >>>> Regards, >>>> Devraj Ajmera >>>> >>>
0001-lavf-whip-mark-RTP-muxer-lookup-as-unreachable.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
