>>
>> rstrip_spaces_buf(dst);
>> av_bprintf(dst, "\\N");
>> line_start = 1;
>> @@ -90,6 +105,15 @@ void ff_htmlmarkup_to_ass(AVCodecContext *avctx,
>> AVBPrint *dst, const char *in)
>> av_bprint_chars(dst, *in, 1);
>> break;
>> case '<':
>> + if (!av_strncasecmp(in, "<BR", 3)){
>>
>> here and below, check your style
>>
>> + av_bprintf(dst, "\\N");
>> + len = 3;
>> + while (in[len] != '>' && (av_isspace(in[len]) || in[len] ==
>> '/')){
>>
>> if in[len] is a space or a '/', it's obviously different than '>', so the
>> condition is redundant.
>>
>> + len++;
>>
>> wrong indent
>>
>> + }
>>
>> + in += len + 1;
>>
>> this +1 is very dangerous, there is a risk of overread.
>
> Well, I was not sure what it could be replaced for checking the closed
> '>' for the <br > tag..
> So this one stayed... Please let me know if you have any suggestion.
>
> Thank you!
Okay I realized that this is rather silly. So the above code is
removed and moved back to
samidec.c now.
>
>
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
