Should prevent potential memory leaks on invalid files.
Signed-off-by: James Almer <[email protected]>
---
libavformat/iamf_parse.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c
index f71ea5315b..db40ae37ab 100644
--- a/libavformat/iamf_parse.c
+++ b/libavformat/iamf_parse.c
@@ -752,11 +752,19 @@ static int audio_element_obu(void *s, IAMFContext *c,
AVIOContext *pb, int len)
type = ffio_read_leb(pbc);
if (type == AV_IAMF_PARAMETER_DEFINITION_MIX_GAIN)
ret = AVERROR_INVALIDDATA;
- else if (type == AV_IAMF_PARAMETER_DEFINITION_DEMIXING)
+ else if (type == AV_IAMF_PARAMETER_DEFINITION_DEMIXING) {
+ if (element->demixing_info) {
+ ret = AVERROR_INVALIDDATA;
+ goto fail;
+ }
ret = param_parse(s, c, pbc, type, audio_element,
&element->demixing_info);
- else if (type == AV_IAMF_PARAMETER_DEFINITION_RECON_GAIN)
+ } else if (type == AV_IAMF_PARAMETER_DEFINITION_RECON_GAIN) {
+ if (element->recon_gain_info) {
+ ret = AVERROR_INVALIDDATA;
+ goto fail;
+ }
ret = param_parse(s, c, pbc, type, audio_element,
&element->recon_gain_info);
- else {
+ } else {
unsigned param_definition_size = ffio_read_leb(pbc);
avio_skip(pbc, param_definition_size);
}
--
2.48.1
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
