On Thu, Feb 13, 2025 at 1:12 PM Devin Heitmueller < [email protected]> wrote:
> On Thu, Feb 13, 2025 at 3:00 PM Pavel Koshevoy <[email protected]> > wrote: > > yes, that patch is better in that it doesn't over-allocate. > > I don't care much which fix gets merged, so long as the problem is fixed. > > Ok, if you could please try that patch and assuming it works for you > reply to the list accordingly. I tried it two years ago (which is how > I found a bug in it), but it would be good to have someone else test > it before it gets merged. I've tested it with 3 files (2 with both cdat and cdt2, and 1 with just cdat) -- it worked fine. This patch doesn't handle potential integer overflow in `new_size = ((size - 8) / 2) * 3;`, but idk if `av_new_packet` would handle that instead. Anyway, I just want this function fixed, I don't care who fixes it. Thank you, Pavel. _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
