On Mon, Dec 23, 2024 at 11:18 PM flow gg <[email protected]> wrote:
> Hi, It looks like you submitted your review comments not long after the > patch was merged. > > Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V > side. No clue about the VVC side", > so I contacted Nuomi in the hope that he could help merge the patch that > had been pending for a while. > Hi Remi, Yes, v2 has been on the mailing list for about two weeks. I also shared that I planned to merge it within two days. https://patchwork.ffmpeg.org/project/ffmpeg/patch/[email protected]/#89698 Are there any best practices to avoid such situations in the future? Would it be better if you handled merging all RISC-V code? Thank you. > > Maybe I pinged too quickly, which led to a misunderstanding that everything > was already fine. > > Please don’t be upset... > > Rémi Denis-Courmont <[email protected]> 于2024年12月23日周一 19:42写道： > > > Hello, > > > > I remember agreeing to rename files. I do not remember agreeing to > merging > > this > > new functionality. To the contrary, this patch had objections from me, > and > > not > > just about performance. The functional issues are not even addressed > here. > > > > Why the heck was this broken SAD code merged when the area maintainer > (me) > > had > > unchallenged objections to it? > > > > And -1 because this is still broken. This should be reverted entirely. > > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > [email protected] > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > [email protected] with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
