On 12/16/2024 12:46 PM, Tomas Härdin wrote:
From f6d28d84413f2f674cfac86d4ed0868e8afb604b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <[email protected]>
Date: Mon, 16 Dec 2024 16:15:47 +0100
Subject: [PATCH 5/6] Add more FATE tests for fragmented MP4

This tests the number of seeks performed when probing fmp4 with and without sidx
Also add tests for the duration, which should be 10 minutes in both cases
Use the same reference for both probe tests
---
 tests/fate/mov.mak            |  9 +++++++
 tests/ref/fate/mov-mfra       |  1 +
 tests/ref/fate/mov-mfra-probe | 51 +++++++++++++++++++++++++++++++++++
 tests/ref/fate/mov-sidx       |  1 +
 4 files changed, 62 insertions(+)
 create mode 100644 tests/ref/fate/mov-mfra
 create mode 100644 tests/ref/fate/mov-mfra-probe
 create mode 100644 tests/ref/fate/mov-sidx

diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak
index ca13ebfd44..3087a11cbc 100644
--- a/tests/fate/mov.mak
+++ b/tests/fate/mov.mak
@@ -284,6 +284,15 @@ fate-mov-mp4-iamf-ambisonic_1: CMD = transcode wav $(SRC) mp4 
"-auto_conversion_
   -streamid 0:0 -streamid 1:1 -streamid 2:2 -streamid 3:3 -map [MONO0] -map [MONO1] -map 
[MONO2] -map [MONO3] -c:a flac -t 1" "-c:a copy -map 0" \
   "-show_entries 
stream_group=index,id,nb_streams,type:stream_group_components:stream_group_disposition:stream_group_tags:stream_group_stream=index,id:stream_group_stream_disposition"
+FATE_MOV_FFPROBE-$(call ALLYES, MOV_DEMUXER FILE_PROTOCOL) += fate-mov-mfra fate-mov-sidx fate-mov-mfra-probe fate-mov-sidx-probe
+fate-mov-mfra fate-mov-mfra-probe: SRC = $(TARGET_SAMPLES)/mov/frags-mfra.mp4
+fate-mov-sidx fate-mov-sidx-probe: SRC = $(TARGET_SAMPLES)/mov/frags-sidx.mp4
+fate-mov-mfra fate-mov-sidx: CMD = run ffprobe -loglevel debug -i $(SRC) 2>&1 | grep 
Statistics | sed -e "s/.*bytes read, //"
+# share REF between both probe tests
+# we want the same behavior regardless of whether sidx is present or not
+fate-mov-mfra-probe fate-mov-sidx-probe: REF = tests/ref/fate/mov-mfra-probe

This is not working. It complains about missing the reference file.
Just remove the line altogether and let fate-mov-sidx-probe have its own reference file in the tree, even if it's the same. We do it for many other tests. Git compresses it anyway.

+fate-mov-mfra-probe fate-mov-sidx-probe: CMD = run ffprobe -show_streams -i 
$(SRC)
+
 FATE_FFMPEG += $(FATE_MOV_FFMPEG-yes)
 FATE_FFMPEG_FFPROBE += $(FATE_MOV_FFMPEG_FFPROBE-yes)
diff --git a/tests/ref/fate/mov-mfra b/tests/ref/fate/mov-mfra
new file mode 100644
index 0000000000..299d3159ab
--- /dev/null
+++ b/tests/ref/fate/mov-mfra
@@ -0,0 +1 @@
+6 seeks
diff --git a/tests/ref/fate/mov-mfra-probe b/tests/ref/fate/mov-mfra-probe
new file mode 100644
index 0000000000..c07f72e0ec
--- /dev/null
+++ b/tests/ref/fate/mov-mfra-probe
@@ -0,0 +1,51 @@
+[STREAM]
+index=0
+codec_name=pcm_s16le
+codec_long_name=PCM signed 16-bit little-endian
+profile=unknown
+codec_type=audio
+codec_tag_string=ipcm
+codec_tag=0x6d637069
+sample_fmt=s16
+sample_rate=44100
+channels=1
+channel_layout=unknown
+bits_per_sample=16
+initial_padding=0
+id=0x1
+r_frame_rate=0/0
+avg_frame_rate=0/0
+time_base=1/44100
+start_pts=0
+start_time=0.000000
+duration_ts=26460000
+duration=600.000000
+bit_rate=705600
+max_bit_rate=N/A
+bits_per_raw_sample=N/A
+nb_frames=31744
+nb_read_frames=N/A
+nb_read_packets=N/A
+DISPOSITION:default=1
+DISPOSITION:dub=0
+DISPOSITION:original=0
+DISPOSITION:comment=0
+DISPOSITION:lyrics=0
+DISPOSITION:karaoke=0
+DISPOSITION:forced=0
+DISPOSITION:hearing_impaired=0
+DISPOSITION:visual_impaired=0
+DISPOSITION:clean_effects=0
+DISPOSITION:attached_pic=0
+DISPOSITION:timed_thumbnails=0
+DISPOSITION:non_diegetic=0
+DISPOSITION:captions=0
+DISPOSITION:descriptions=0
+DISPOSITION:metadata=0
+DISPOSITION:dependent=0
+DISPOSITION:still_image=0
+DISPOSITION:multilayer=0
+TAG:language=und
+TAG:handler_name=SoundHandler
+TAG:vendor_id=[0][0][0][0]
+[/STREAM]
diff --git a/tests/ref/fate/mov-sidx b/tests/ref/fate/mov-sidx
new file mode 100644
index 0000000000..d24055e37b
--- /dev/null
+++ b/tests/ref/fate/mov-sidx
@@ -0,0 +1 @@
+3 seeks
--
2.39.2


Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".

Reply via email to