On 07/10/2024 09:28, Hendrik Leppkes wrote:
On Mon, Oct 7, 2024 at 9:15 AM Lynne via ffmpeg-devel
<[email protected]> wrote:

If someone were to enable libglslang/libshaderc, and then disable
all Vulkan filters, they would have the same issue as the earlier
fix for libavcodec.

If you run such a setup, shouldn't the code that uses this then be excluded?

No, the files are always compiled if the user enabled support.
> OBJS-$(CONFIG_LIBGLSLANG)                    += vulkan_glslang.o
> OBJS-$(CONFIG_LIBSHADERC)                    += vulkan_shaderc.o

We do the same for qsv.
If we only supported a single SPIRV compiler, we could have instead added the file to every filter, but unfortunately, both libraries are used more or less equally by distributions and users.

Attachment: OpenPGP_0xA2FEA5F03F034464.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".

Reply via email to