On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote:
> On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote:
> [...]
>
> > +static int rcwt_probe(const AVProbeData *p)
> > +{
> > + return p->buf_size > RCWT_HEADER_SIZE &&
> > + AV_RB16(p->buf) == 0xCCCC &&
> > + AV_RB8(p->buf + 2) == 0xED &&
> > + AV_RB16(p->buf + 6) == 0x0001 ? 50 : 0;
> > +}
> > +
> > +const FFInputFormat ff_rcwt_demuxer = {
> > + .p.name = "rcwt",
> > + .p.long_name = NULL_IF_CONFIG_SMALL("RCWT (Raw Captions With
> > Time)"),
> > + .p.extensions = "bin",
>
> this causes a mp3 i have to be misdetected
> ~/videos/sbQ9.bin
> (this is a actual file i had not a file crafted for this)
>
> i think the entry for extensions should be removed (which fixes this)
> having a ".bin" is not a strong indication that its rcwt
Is this blocking or can it be addressed later? Also, if this needs to
be modified the muxer should be as well.
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
