Thanks all for the feedback. I think I took the idea too literally here, and agree in retrospect it’s not necessary at this point. The good news is while I made this change, I didn’t find any pre-existing bugs in this demuxer due to using the pattern. (Because while I was writing it, I had made the mistake a few times and was able to correct them :D)
I think we can skip this and if it becomes an issue down the line I’ll make the changes surgically. Going forward for my own contributions, I’ll avoid the pattern unless it truly offers readability gain. Apologies for the inconvenience. Best, Marth64 _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
