On Tue, Jan 2, 2024 at 11:57 PM Lynne <[email protected]> wrote: > Jan 2, 2024, 14:22 by [email protected]: > > > On Mon, Jan 1, 2024 at 11:13 PM Lynne <[email protected]> wrote: > > > >> > >> > >> > >> Jan 1, 2024, 15:14 by [email protected]: > >> > >> > + > >> > +//fixme > >> > +static void vvc_refill2(CABACContext* c) { > >> > > >> > >> Fix what? > >> Also, wrong coding style. > >> > > The function is a copy of refill2 in cabac_functions.h, including the > style. > > The refill2 is protected by get_cabac_inline. > > On x86, get_cabac_inline is only defined when HAVE_7REGS && > > !BROKEN_COMPILER is true. > > It can be challenging to figure out how to get refill2 defined in this > > context. > > Let us use https://github.com/ffvvc/FFmpeg/issues/178 to track this > > > > Are you thinking about sharing the code later on? > If not, then there's no reason to have the duplicated function > and style issues. > Yes, I will remove it and use refill2. But I need help from the original author, @Michael
> _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
