Jan 1, 2024, 15:15 by [email protected]:
> +
> +////////////////////////////////////////////////////////////////////////////////
> +//
> +////////////////////////////////////////////////////////////////////////////////
>
What's with these markers?
> +static void FUNC(put_pixels)(int16_t *dst,
> + const uint8_t *_src, const ptrdiff_t _src_stride,
> + const int height, const int8_t *hf, const int8_t *vf, const int width)
> +{
> + const pixel *src = (const pixel *)_src;
> + const ptrdiff_t src_stride = _src_stride / sizeof(pixel);
> +
> + for (int y = 0; y < height; y++) {
> + for (int x = 0; x < width; x++)
> + dst[x] = src[x] << (14 - BIT_DEPTH);
> + src += src_stride;
> + dst += MAX_PB_SIZE;
> + }
> +}
>
av_image_copy(AV_PIX_FMT_GRAY14, input_format)?
Also, why is the decoder using 14-bits internally rather than expanding
it to 16-bits? Headroom to avoid overflows?
> +
> +static void FUNC(put_uni_pixels)(uint8_t *_dst, const ptrdiff_t _dst_stride,
> + const uint8_t *_src, const ptrdiff_t _src_stride, const int height,
> + const int8_t *hf, const int8_t *vf, const int width)
> +{
> + const pixel *src = (const pixel *)_src;
> + pixel *dst = (pixel *)_dst;
> + const ptrdiff_t src_stride = _src_stride / sizeof(pixel);
> + const ptrdiff_t dst_stride = _dst_stride / sizeof(pixel);
> +
> + for (int y = 0; y < height; y++) {
> + memcpy(dst, src, width * sizeof(pixel));
> + src += src_stride;
> + dst += dst_stride;
> + }
> +}
>
av_image_copy()?
Also, this function is identical for all bit depths.
> +
> +enum TxType {
> + DCT2,
> + DST7,
> + DCT8,
> + N_TX_TYPE,
> +};
> +
> +enum TxSize {
> + TX_SIZE_2,
> + TX_SIZE_4,
> + TX_SIZE_8,
> + TX_SIZE_16,
> + TX_SIZE_32,
> + TX_SIZE_64,
> + N_TX_SIZE,
> +};
>
Could you prefix these enums with VVC_?
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
