On Tue, Sep 19, 2023 at 8:40 PM Neal Gompa <[email protected]> wrote: > > On Mon, Sep 11, 2023 at 3:52 AM <[email protected]> wrote: > > > > From: Fei Wang <[email protected]> > > > > Signed-off-by: Fei Wang <[email protected]> > > --- > > libavcodec/av1.h | 7 +++++++ > > libavcodec/cbs_av1_syntax_template.c | 4 ++-- > > 2 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/av1.h b/libavcodec/av1.h > > index 384f7cddc7..8704bc41c1 100644 > > --- a/libavcodec/av1.h > > +++ b/libavcodec/av1.h > > @@ -175,6 +175,13 @@ enum { > > AV1_RESTORE_SWITCHABLE = 3, > > }; > > > > +// TX mode (section 6.8.21) > > +enum { > > + AV1_ONLY_4X4 = 0, > > + AV1_TX_MODE_LARGEST = 1, > > + AV1_TX_MODE_SELECT = 2, > > +}; > > + > > // Sequence Headers are actually unbounded because one can use > > // an arbitrary number of leading zeroes when encoding via uvlc. > > // The following estimate is based around using the lowest number > > diff --git a/libavcodec/cbs_av1_syntax_template.c > > b/libavcodec/cbs_av1_syntax_template.c > > index 6f09c4e410..3be1f2d30f 100644 > > --- a/libavcodec/cbs_av1_syntax_template.c > > +++ b/libavcodec/cbs_av1_syntax_template.c > > @@ -1028,9 +1028,9 @@ static int FUNC(read_tx_mode)(CodedBitstreamContext > > *ctx, RWContext *rw, > > int err; > > > > if (priv->coded_lossless) > > - infer(tx_mode, 0); > > + infer(tx_mode, AV1_ONLY_4X4); > > else > > - increment(tx_mode, 1, 2); > > + increment(tx_mode, AV1_TX_MODE_LARGEST, AV1_TX_MODE_SELECT); > > > > return 0; > > } > > -- > > 2.25.1 > > > > Code looks good to me, I just lack hardware to exercise the functionality. > > Acked-by: Neal Gompa <[email protected]> >
Actually, update this now that I'm giving feedback for each patch individually. This patch is fine and works with my existing software AV1 path, so... Reviewed-by: Neal Gompa <[email protected]> -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
