Stefano Sabatini:
> +int sws_get_gaussian_vec(SwsVector **vecp,
> + AVClass *log_ctx,
> + double standard_deviation, double quality);
>
Seriously? A pointer to an AVClass as log_ctx? It is actually AVClass**
(the logcontext must have a pointer to an AVClass as its first member),
but we always use NULL.
Apart from that: I am not really convinced that the improvement is worth
the hassle.
>
> + if (standard_deviation < 0 || quality < 0) {
> + av_log(NULL, AV_LOG_ERROR,
> + "Invalid negative standard deviation %f or quality %f
> provided as input to the sws_get_gaussian_vec function\n",
> + standard_deviation, quality);
Here you are not even using the logctx.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
