On Thu, 31 Aug 2023 at 15:12, Carotti, Elias via ffmpeg-devel < [email protected]> wrote:
> Hi > > -----Original Message----- > From: ffmpeg-devel <[email protected]> On Behalf Of Stefano > Sabatini > Sent: Friday, August 25, 2023 12:01 PM > To: FFmpeg development discussions and patches <[email protected]> > Cc: Stefano Sabatini <[email protected]> > Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable > x4->params.analyse.b_fast_pskip if mb_info is set > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > x4->params.analyse.b_fast_pskip should only be forced in case mb_info > is set. > > Fix output change introduced in 418c954e318. > --- > libavcodec/libx264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index > 1a7dc7bdd5..a2877d7f75 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -1190,7 +1190,9 @@ FF_ENABLE_DEPRECATION_WARNINGS > } > > x4->params.analyse.b_mb_info = x4->mb_info; > - x4->params.analyse.b_fast_pskip = 1; > + if (x4->mb_info) { > + x4->params.analyse.b_fast_pskip = x4->mb_info; > + } > > // update AVCodecContext with x264 parameters > avctx->has_b_frames = x4->params.i_bframe ? > -- > 2.25.1 > > > Sorry for the delay. I agree, this was missing in the patch. > Best > Elias > What does this patch actually do? Kieran _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
