On Sat, Jul 1, 2023 at 4:11 AM Anton Khirnov <[email protected]> wrote: > > /** > > + * Bar data - used by side data for avcodec and avframe. Defines the > > location > > + * of horizontal or vertical black bars (i.e. letterbox/pillar bars) > > + */ > > +typedef struct AVBarData { > > + int top_bottom; /* 0=top/bottom 1=left/right */ > > + int top; > > + int left; > > + int bottom; > > + int right; > > Am I understanding correctly that half of these are never used for a > given AVBarData instance? Seems wasteful. Could make it a generic > bound0, bound1 or a union instead.
It was only an extra eight bytes per video frame, so I wasn't particularly worried about the size. That said, perhaps a union would make it more clear that you can't set both simultaneously. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: [email protected] _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
