[FFmpeg-devel] ?????? [PATCH] avcodec/videotoolboxenc: replace VT_H264Profile with avctx profile

?????? Sun, 21 May 2023 21:20:46 -0700

It's my mistake that forget to remove H264_PROF_AUTO. I will fix that.
Any other suggestions about the profile_options? Thanks.



------------------&nbsp;????????&nbsp;------------------
??????:                                                                         
                                               ""zhilizhao(??????)""            
                                                                        
<[email protected]&gt;;
????????:&nbsp;2023??5??22??(??????) ????11:11
??????:&nbsp;"FFmpeg development discussions and 
patches"<[email protected]&gt;;
????:&nbsp;"??????"<[email protected]&gt;;"Rick Kern"<[email protected]&gt;;
????:&nbsp;Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: replace 
VT_H264Profile with avctx profile





&gt; On May 22, 2023, at 11:05, zhilizhao(??????) <[email protected]&gt; 
wrote:
&gt; 
&gt;&gt; On May 21, 2023, at 22:41, xufuji456 <[email protected]&gt; wrote:
&gt;&gt; 
&gt;&gt; For compatibility with constrained_baseline in the future,
&gt;&gt; replace VT_H264Profile/VT_HEVCProfile with avctx-&gt;profile.
&gt;&gt; 
&gt;&gt; Signed-off-by: xufuji456 <[email protected]&gt;
&gt;&gt; ---
&gt;&gt; libavcodec/videotoolboxenc.c | 55 +++++++++++-------------------------
&gt;&gt; 1 file changed, 16 insertions(+), 39 deletions(-)
&gt;&gt; 
&gt;&gt; diff --git a/libavcodec/videotoolboxenc.c 
b/libavcodec/videotoolboxenc.c
&gt;&gt; index b017c90c36..4966ab36ae 100644
&gt;&gt; --- a/libavcodec/videotoolboxenc.c
&gt;&gt; +++ b/libavcodec/videotoolboxenc.c
&gt;&gt; @@ -190,28 +190,12 @@ static void loadVTEncSymbols(void){
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 "EnableLowLatencyRateControl");
&gt;&gt; }
&gt;&gt; 
&gt;&gt; -typedef enum VT_H264Profile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_BASELINE,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_HIGH,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_EXTENDED,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_COUNT
&gt;&gt; -} VT_H264Profile;
&gt;&gt; -
&gt;&gt; typedef enum VTH264Entropy{
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_ENTROPY_NOT_SET,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CAVLC,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CABAC
&gt;&gt; } VTH264Entropy;
&gt;&gt; 
&gt;&gt; -typedef enum VT_HEVCProfile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN10,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_COUNT
&gt;&gt; -} VT_HEVCProfile;
&gt;&gt; -
&gt;&gt; static const uint8_t start_code[] = { 0, 0, 0, 1 };
&gt;&gt; 
&gt;&gt; typedef struct ExtraSEI {
&gt;&gt; @@ -730,18 +714,13 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; VTEncContext *vtctx = avctx-&gt;priv_data;
&gt;&gt;&nbsp;&nbsp;&nbsp; int64_t profile = vtctx-&gt;profile;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp; if (profile == H264_PROF_AUTO &amp;&amp; 
vtctx-&gt;level) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; //Need to pick a profile 
if level is not auto-selected.
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; profile = 
vtctx-&gt;has_b_frames ? H264_PROF_MAIN : H264_PROF_BASELINE;
&gt;&gt; -&nbsp;&nbsp;&nbsp; }
&gt;&gt; -
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_AUTO:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
return true;

Isn??t it failed to build since H264_PROF_AUTO isn??t defined?

&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_BASELINE:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_H264_BASELINE:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Baseline_AutoLevel; break;
&gt;&gt; @@ -763,7 +742,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Main_AutoLevel; break;
&gt;&gt; @@ -782,7 +761,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_HIGH:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_HIGH:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_High_AutoLevel; break;
&gt;&gt; @@ -805,7 +784,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_High_5_2;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_EXTENDED:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_H264_EXTENDED:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Extended_AutoLevel; break;
&gt;&gt; @@ -838,13 +817,11 @@ static bool 
get_vt_hevc_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_AUTO:
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
return true;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
*profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_HEVC_Main_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN10:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_HEVC_MAIN_10:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
*profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_HEVC_Main10_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; @@ -1515,12 +1492,12 @@ static int 
vtenc_configure_encoder(AVCodecContext *avctx)
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;get_param_set_func 
= CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = 
avctx-&gt;max_b_frames &gt; 0;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames 
&amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE){
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames 
&amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
av_log(avctx, AV_LOG_WARNING, "Cannot use B-frames with baseline profile. 
Output will not contain B-frames.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
vtctx-&gt;has_b_frames = 0;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == 
VT_CABAC &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE) {
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == 
VT_CABAC &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
av_log(avctx, AV_LOG_WARNING, "CABAC entropy requires 'main' or 'high' profile, 
but baseline was requested. Encode will not use CABAC entropy.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
vtctx-&gt;entropy = VT_ENTROPY_NOT_SET;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; @@ -2756,11 +2733,11 @@ static const enum AVPixelFormat 
prores_pix_fmts[] = {
&gt;&gt; 
&gt;&gt; #define OFFSET(x) offsetof(VTEncContext, x)
&gt;&gt; static const AVOption h264_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = H264_PROF_AUTO }, H264_PROF_AUTO, H264_PROF_COUNT, 
VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, 
AV_OPT_TYPE_CONST, { .i64 = H264_PROF_BASELINE }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
H264_PROF_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
H264_PROF_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, 
AV_OPT_TYPE_CONST, { .i64 = H264_PROF_EXTENDED }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_H264_BASELINE }, 
FF_PROFILE_H264_BASELINE, FF_PROFILE_H264_HIGH, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, 
AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_BASELINE }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_H264_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" 
},
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, 
AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_EXTENDED }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_H264_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" 
},
&gt; 
&gt; Firstly, it breaks use case which set the option by number like -profile 1.
&gt; 
&gt; Secondly, it changes the default profile to baseline. I don??t think it??s 
a
&gt; good idea.
&gt; 
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "level", "Level", OFFSET(level), AV_OPT_TYPE_INT, 
{ .i64 = 0 }, 0, 52, VE, "level" },
&gt;&gt;&nbsp;&nbsp;&nbsp; { "1.3", "Level 1.3, only available with Baseline 
Profile", 0, AV_OPT_TYPE_CONST, { .i64 = 13 }, INT_MIN, INT_MAX, VE, "level" },
&gt;&gt; @@ -2811,9 +2788,9 @@ const FFCodec ff_h264_videotoolbox_encoder = {
&gt;&gt; };
&gt;&gt; 
&gt;&gt; static const AVOption hevc_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = HEVC_PROF_AUTO }, HEVC_PROF_AUTO, HEVC_PROF_COUNT, 
VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
HEVC_PROF_MAIN&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 
Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN10 }, 
INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_HEVC_MAIN }, FF_PROFILE_HEVC_MAIN, 
FF_PROFILE_HEVC_MAIN_10, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_HEVC_MAIN&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 
Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN_10 }, 
INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "alpha_quality", "Compression quality for the 
alpha channel", OFFSET(alpha_quality), AV_OPT_TYPE_DOUBLE, { .dbl = 0.0 }, 0.0, 
1.0, VE },
&gt;&gt; 
&gt;&gt; -- 
&gt;&gt; 2.32.0 (Apple Git-132)
&gt;&gt; 
&gt;&gt; _______________________________________________
&gt;&gt; ffmpeg-devel mailing list
&gt;&gt; [email protected]
&gt;&gt; https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
&gt;&gt; 
&gt;&gt; To unsubscribe, visit link above, or email
&gt;&gt; [email protected] with subject "unsubscribe".
&gt; 
&gt;&gt; On May 21, 2023, at 22:41, xufuji456 <[email protected]&gt; wrote:
&gt;&gt; 
&gt;&gt; For compatibility with constrained_baseline in the future,
&gt;&gt; replace VT_H264Profile/VT_HEVCProfile with avctx-&gt;profile.
&gt;&gt; 
&gt;&gt; Signed-off-by: xufuji456 <[email protected]&gt;
&gt;&gt; ---
&gt;&gt; libavcodec/videotoolboxenc.c | 55 +++++++++++-------------------------
&gt;&gt; 1 file changed, 16 insertions(+), 39 deletions(-)
&gt;&gt; 
&gt;&gt; diff --git a/libavcodec/videotoolboxenc.c 
b/libavcodec/videotoolboxenc.c
&gt;&gt; index b017c90c36..4966ab36ae 100644
&gt;&gt; --- a/libavcodec/videotoolboxenc.c
&gt;&gt; +++ b/libavcodec/videotoolboxenc.c
&gt;&gt; @@ -190,28 +190,12 @@ static void loadVTEncSymbols(void){
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 "EnableLowLatencyRateControl");
&gt;&gt; }
&gt;&gt; 
&gt;&gt; -typedef enum VT_H264Profile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_BASELINE,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_HIGH,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_EXTENDED,
&gt;&gt; -&nbsp;&nbsp;&nbsp; H264_PROF_COUNT
&gt;&gt; -} VT_H264Profile;
&gt;&gt; -
&gt;&gt; typedef enum VTH264Entropy{
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_ENTROPY_NOT_SET,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CAVLC,
&gt;&gt;&nbsp;&nbsp;&nbsp; VT_CABAC
&gt;&gt; } VTH264Entropy;
&gt;&gt; 
&gt;&gt; -typedef enum VT_HEVCProfile {
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_AUTO,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_MAIN10,
&gt;&gt; -&nbsp;&nbsp;&nbsp; HEVC_PROF_COUNT
&gt;&gt; -} VT_HEVCProfile;
&gt;&gt; -
&gt;&gt; static const uint8_t start_code[] = { 0, 0, 0, 1 };
&gt;&gt; 
&gt;&gt; typedef struct ExtraSEI {
&gt;&gt; @@ -730,18 +714,13 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; VTEncContext *vtctx = avctx-&gt;priv_data;
&gt;&gt;&nbsp;&nbsp;&nbsp; int64_t profile = vtctx-&gt;profile;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp; if (profile == H264_PROF_AUTO &amp;&amp; 
vtctx-&gt;level) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; //Need to pick a profile 
if level is not auto-selected.
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; profile = 
vtctx-&gt;has_b_frames ? H264_PROF_MAIN : H264_PROF_BASELINE;
&gt;&gt; -&nbsp;&nbsp;&nbsp; }
&gt;&gt; -
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_AUTO:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
return true;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_BASELINE:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_H264_BASELINE:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Baseline_AutoLevel; break;
&gt;&gt; @@ -763,7 +742,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Main_AutoLevel; break;
&gt;&gt; @@ -782,7 +761,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_HIGH:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_H264_HIGH:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_High_AutoLevel; break;
&gt;&gt; @@ -805,7 +784,7 @@ static bool 
get_vt_h264_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_High_5_2;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case H264_PROF_EXTENDED:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_H264_EXTENDED:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
switch (vtctx-&gt;level) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 case&nbsp; 0: *profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_H264_Extended_AutoLevel; break;
&gt;&gt; @@ -838,13 +817,11 @@ static bool 
get_vt_hevc_profile_level(AVCodecContext *avctx,
&gt;&gt;&nbsp;&nbsp;&nbsp; *profile_level_val = NULL;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; switch (profile) {
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_AUTO:
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
return true;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case FF_PROFILE_HEVC_MAIN:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
*profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_HEVC_Main_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case HEVC_PROF_MAIN10:
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; case 
FF_PROFILE_HEVC_MAIN_10:
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
*profile_level_val =
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 compat_keys.kVTProfileLevel_HEVC_Main10_AutoLevel;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
break;
&gt;&gt; @@ -1515,12 +1492,12 @@ static int 
vtenc_configure_encoder(AVCodecContext *avctx)
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;get_param_set_func 
= CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; vtctx-&gt;has_b_frames = 
avctx-&gt;max_b_frames &gt; 0;
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames 
&amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE){
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if(vtctx-&gt;has_b_frames 
&amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
av_log(avctx, AV_LOG_WARNING, "Cannot use B-frames with baseline profile. 
Output will not contain B-frames.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
vtctx-&gt;has_b_frames = 0;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; 
&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == 
VT_CABAC &amp;&amp; vtctx-&gt;profile == H264_PROF_BASELINE) {
&gt;&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (vtctx-&gt;entropy == 
VT_CABAC &amp;&amp; vtctx-&gt;profile == FF_PROFILE_H264_BASELINE) {
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
av_log(avctx, AV_LOG_WARNING, "CABAC entropy requires 'main' or 'high' profile, 
but baseline was requested. Encode will not use CABAC entropy.\n");
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
vtctx-&gt;entropy = VT_ENTROPY_NOT_SET;
&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&gt; @@ -2756,11 +2733,11 @@ static const enum AVPixelFormat 
prores_pix_fmts[] = {
&gt;&gt; 
&gt;&gt; #define OFFSET(x) offsetof(VTEncContext, x)
&gt;&gt; static const AVOption h264_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = H264_PROF_AUTO }, H264_PROF_AUTO, H264_PROF_COUNT, 
VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, 
AV_OPT_TYPE_CONST, { .i64 = H264_PROF_BASELINE }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
H264_PROF_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
H264_PROF_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, 
AV_OPT_TYPE_CONST, { .i64 = H264_PROF_EXTENDED }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_H264_BASELINE }, 
FF_PROFILE_H264_BASELINE, FF_PROFILE_H264_HIGH, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "baseline", "Baseline Profile", 0, 
AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_BASELINE }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_H264_MAIN&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" 
},
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "extended", "Extend Profile",&nbsp;&nbsp; 0, 
AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_H264_EXTENDED }, INT_MIN, INT_MAX, VE, 
"profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "high",&nbsp;&nbsp;&nbsp;&nbsp; "High 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_H264_HIGH&nbsp;&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" 
},
&gt; 
&gt; Firstly, it breaks use case which set the option by number like -profile 1.
&gt; 
&gt; Secondly, it changes the default profile to baseline. I don??t think it??s 
a
&gt; good idea.
&gt; 
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "level", "Level", OFFSET(level), AV_OPT_TYPE_INT, 
{ .i64 = 0 }, 0, 52, VE, "level" },
&gt;&gt;&nbsp;&nbsp;&nbsp; { "1.3", "Level 1.3, only available with Baseline 
Profile", 0, AV_OPT_TYPE_CONST, { .i64 = 13 }, INT_MIN, INT_MAX, VE, "level" },
&gt;&gt; @@ -2811,9 +2788,9 @@ const FFCodec ff_h264_videotoolbox_encoder = {
&gt;&gt; };
&gt;&gt; 
&gt;&gt; static const AVOption hevc_options[] = {
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = HEVC_PROF_AUTO }, HEVC_PROF_AUTO, HEVC_PROF_COUNT, 
VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
HEVC_PROF_MAIN&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; -&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 
Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = HEVC_PROF_MAIN10 }, 
INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "profile", "Profile", OFFSET(profile), 
AV_OPT_TYPE_INT64, { .i64 = FF_PROFILE_HEVC_MAIN }, FF_PROFILE_HEVC_MAIN, 
FF_PROFILE_HEVC_MAIN_10, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main",&nbsp;&nbsp;&nbsp;&nbsp; "Main 
Profile",&nbsp;&nbsp;&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = 
FF_PROFILE_HEVC_MAIN&nbsp;&nbsp;&nbsp; }, INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; +&nbsp;&nbsp;&nbsp; { "main10",&nbsp;&nbsp; "Main10 
Profile",&nbsp;&nbsp; 0, AV_OPT_TYPE_CONST, { .i64 = FF_PROFILE_HEVC_MAIN_10 }, 
INT_MIN, INT_MAX, VE, "profile" },
&gt;&gt; 
&gt;&gt;&nbsp;&nbsp;&nbsp; { "alpha_quality", "Compression quality for the 
alpha channel", OFFSET(alpha_quality), AV_OPT_TYPE_DOUBLE, { .dbl = 0.0 }, 0.0, 
1.0, VE },
&gt;&gt; 
&gt;&gt; -- 
&gt;&gt; 2.32.0 (Apple Git-132)
&gt;&gt; 
&gt;&gt; _______________________________________________
&gt;&gt; ffmpeg-devel mailing list
&gt;&gt; [email protected]
&gt;&gt; https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
&gt;&gt; 
&gt;&gt; To unsubscribe, visit link above, or email
&gt;&gt; [email protected] with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".

[FFmpeg-devel] ?????? [PATCH] avcodec/videotoolboxenc: replace VT_H264Profile with avctx profile

Reply via email to