On 4/29/2023 6:13 AM, Nicolas George wrote:
Anton Khirnov (12023-04-29):
That does not follow at all - just because something was moved once does
not mean it cannot be moved again if a better place is found later.
Good, then you should have no objection to replacing your private
structure with a “/* these fields are private to… */” comment.
History has shown that these notifications have had no effect on users,
and even on this same project's developers. A good example was
ffserver.c, which accessed an unholy amount of lavf private fields (both
exposed in public headers and even internal ones), and first_dts from
AVStream, which was not only accessed by prominent library users (One of
which refuses to do things right and forces distros to use a patch to
expose said field on their ffmpeg packages for the sake of supporting
their application, thus making a pure recompilation from our tree no
longer a drop-in solution on anyone's system), but also by ffmpeg.c,
with no developer noticing it to prevent such code being pushed.
So no, i don't support a simple "please, don't touch the shinny and
enticing object in the table" notifications. If in the future this
approach here is replaced, it needs to be by something better/cleaner
that also keeps things local.
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
