Quoting Paul B Mahol (2022-09-25 19:16:43) > Patch attached > > From 0a28ae573654d05ef56cafbb169674b1829f0c6f Mon Sep 17 00:00:00 2001 > From: Paul B Mahol <[email protected]> > Date: Sun, 25 Sep 2022 19:17:25 +0200 > Subject: [PATCH] avcodec/mjpegdec: check that index is not negative > > Signed-off-by: Paul B Mahol <[email protected]> > --- > libavcodec/mjpegdec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index c594950500..57c7c1c80d 100644 > --- a/libavcodec/mjpegdec.c > +++ b/libavcodec/mjpegdec.c > @@ -374,6 +374,8 @@ int ff_mjpeg_decode_sof(MJpegDecodeContext *s) > for (i = 0; i < nb_components; i++) { > /* component id */ > s->component_id[i] = get_bits(&s->gb, 8) - 1; > + if (s->component_id[i] < 0)
It's generally safer to not leave invalid values lying around, so better to first check and only then write into the context. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
