> -----Original Message----- > From: [email protected] <[email protected]> On > Behalf Of Andreas Rheinhardt > Sent: 2022年9月23日 23:11 > To: [email protected] > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses > warning > > Zhao Zhili: > > From: Zhao Zhili <[email protected]> > > > > Signed-off-by: Zhao Zhili <[email protected]> > > --- > > libavcodec/mjpegdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > > index c594950500..d77c644d3b 100644 > > --- a/libavcodec/mjpegdec.c > > +++ b/libavcodec/mjpegdec.c > > @@ -2866,7 +2866,7 @@ the_end: > > } > > } > > > > - if (e = av_dict_get(s->exif_metadata, "Orientation", e, > > AV_DICT_IGNORE_SUFFIX)) { > > + if ((e = av_dict_get(s->exif_metadata, "Orientation", e, > > AV_DICT_IGNORE_SUFFIX))) { > > char *value = e->value + strspn(e->value, " \n\t\r"), *endptr; > > int orientation = strtol(value, &endptr, 0); > > > > Since when do we care about this type of warning? Line 7087 of configure > adds -Wno-parentheses in case the compiler supports it.
OK. Before sending the patch, I have checked git log that there is a commit 3fb32ae2 which fixed a bug catched by -Wparentheses. I didn't notice -Wparentheses has been disabled explicitly since too much false positive. On the other hand, I'd like to suggest to avoid such coding style for new code. Please ignore the patch itself. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
