mån 2022-03-14 klockan 20:57 +0100 skrev Marton Balint: > > > On Mon, 14 Mar 2022, Tomas Härdin wrote: > > > mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint: > > > Also make sure we do not change the product UID. > > > > > > Signed-off-by: Marton Balint <[email protected]> > > > --- > > > libavformat/mxfenc.c | 9 +++++---- > > > tests/ref/fate/copy-trac4914 | 2 +- > > > tests/ref/fate/mxf-d10-user-comments | 6 +++--- > > > tests/ref/fate/mxf-opatom-user-comments | 2 +- > > > tests/ref/fate/mxf-reel_name | 2 +- > > > tests/ref/fate/mxf-user-comments | 2 +- > > > tests/ref/fate/time_base | 2 +- > > > tests/ref/lavf/mxf | 6 +++--- > > > tests/ref/lavf/mxf_d10 | 2 +- > > > tests/ref/lavf/mxf_dv25 | 2 +- > > > tests/ref/lavf/mxf_dvcpro50 | 2 +- > > > tests/ref/lavf/mxf_opatom | 2 +- > > > tests/ref/lavf/mxf_opatom_audio | 2 +- > > > 13 files changed, 21 insertions(+), 20 deletions(-) > > > > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > > > index 1e87dc6111..ba8e7babfb 100644 > > > --- a/libavformat/mxfenc.c > > > +++ b/libavformat/mxfenc.c > > > @@ -227,7 +227,8 @@ static const UID mxf_d10_container_uls[] = { > > > { > > > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0D,0x01,0x03,0x01,0x02, > > > 0x01 > > > ,0x06,0x01 }, // D-10 525/50 NTSC 30mb/s > > > }; > > > > > > -static const uint8_t uuid_base[] = { > > > 0xAD,0xAB,0x44,0x24,0x2f,0x25,0x4d,0xc7,0x92,0xff,0x29,0xbd }; > > > +static const uint8_t product_uid[] = { > > > 0xAD,0xAB,0x44,0x24,0x2f,0x25,0x4d,0xc7,0x92,0xff,0x29,0xbd,0x00, > > > 0x0c > > > ,0x00,0x02}; > > > > Maybe use Identification instead of 0x0C. > > Actually I'd rather keep it 0x0C, Identification value might change > (if > MXFMetadataSetType enum is reordered in mxf.h), and we don't want > ProductUID to change even then...
Good point /Tomas _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
