On Feb 9, 2022, 7:31 AM +0800, Jan Ekström <[email protected]>, wrote: > On Tue, Feb 8, 2022 at 9:48 AM Wang Chuan <[email protected]> wrote: > > > > Any news？ > > > > Sorry, was not able to get to this according to the time line I > expected. Will see if I can find some time for this soon. > > The attempt I had done in October was quite similar now that I look at > it again > (https://github.com/jeeb/ffmpeg/commits/enable_writing_udta_metadata_for_tracks), > although it seems like I missed c->trak_index , will have to check it > :) > > Additionally, when I did the changes a lot of tests had to be updated > as the test would expect the metadata in the main context, as > previously the metadata only got applied globally. The changes in my > commit aren't what's needed as I just committed the changes in test > results to remind myself which tests would require additional changes > or at least review. > > Looking at the patchwork side for this patch set, it seems like it > wasn't able to run the tests for you, so you probably did not get any > messages about failing tests? > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5839 > > For running tests locally, what I usually do is: > > 1. configure and build normally > 2. `make fate-rsync SAMPLES=../../path/to/fate-suite` > 3. `make fate SAMPLES=../../path/to/fate-suite` > > this is also documented at https://www.ffmpeg.org/fate.html . Thanks for your reply!
I have tried running tests on my PC, but I didn’t meet any test failure... But if I use your patch, the tests failed. The difference between your patch and my is that you use [s->nb_streams - 1] but I use [c->trak_index]. It seems like [c->trak_index] is a better choice. (It seems like if we use [s->nb_streams - 1], the metadata we read will all go to the last) Can you check this again? Thanks _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
