On Mon, 20 Dec 2021 11:13:15 +0100 Anton Khirnov <[email protected]> wrote: > nit: FF_ARRAY_ELEMS(s->vdr_ref) is considered better
Done. > Would not calling ff_dovi_ctx_unref() be safer here? Good point, changed. > This is only used for logging (as it should be), so you can make this > void *logctx and drop the avcodec.h #include. So, the reason I made this an avctx is because I'm anticipating the need to check `avctx->err_recognition` if the CRC32 check ever gets implemented. In theory we could also do some profile-based verification in AV_EF_BITSTREAM / AV_EF_EXPLODE, to check if the coded RPU values actually match the legal combinations restricted by the profile specification. Of course, given that this is just an internal API, I'm also fine making it a logctx now and upgrading it to an avctx when the need arises. _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
