Lynne<mailto:[email protected]>: Sent: 2021年12月9日 19:26 To: FFmpeg development discussions and patches<mailto:[email protected]> Subject: Re: [FFmpeg-devel] [PATCH v2 3/4] avfilter/gblur_vulkan: fix incorrect semantics
9 Dec 2021, 10:36 by [email protected]: >> The input and output are arrays of images, so it's better to use the plural >> to align them to the variable name of VkDescriptorImageInfo. >> >> Signed-off-by: Wu Jianhua <[email protected]> >> --- >> libavfilter/vf_gblur_vulkan.c | 60 +++++++++++++++++------------------ >> 1 file changed, 30 insertions(+), 30 deletions(-) >> >> diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c >> index a2e33d1c90..2dbbbd0965 100644 >> --- a/libavfilter/vf_gblur_vulkan.c >> +++ b/libavfilter/vf_gblur_vulkan.c >> @@ -50,31 +50,31 @@ typedef struct GBlurVulkanContext { >> } GBlurVulkanContext; >> > > Not going to apply either patch, image[<image_index>] looks > perfectly fine to me, and you didn't need to reindent the entire > shader kernel either. > Alright. I’m really like using the plural for arrays and indentation to make them more clear and concise, but it’s okay to me to drop them if you really don’t like them. _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
