> -----Original Message-----
> From: ffmpeg-devel <[email protected]> On Behalf Of Anton
> Khirnov
> Sent: Monday, December 6, 2021 9:33 AM
> To: [email protected]
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvdsub: Don't dump images to
> disk based on DEBUG define
>
> Quoting Soft Works (2021-11-29 21:17:32)
> > It's been a regular annoyance.
> > Introduce a debug-only parameter for this.
> >
> > Signed-off-by: softworkz <[email protected]>
> > ---
> > libavcodec/dvdsubdec.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Does anyone actually find that code useful? Apparently it's been there
> since 2005, and our standards for what is acceptable have changed
> somewhat.
>
> I would just drop it.`
I think that it can be useful at times to dump the individual subtitle
images to disk. My primary point is that this shouldn't happen based
on whether ffmpeg is compiled with DEBUG or not.
Actually that's functionality that can be implemented in a new subtitle
filter, which would be an ultimate justification to drop this from
dvdsub and dvbsub.
Maybe we can just merge these two patches as an interim solution?
Thanks,
softworkz
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
