On Tue, Nov 9, 2021 at 5:57 AM Steven Liu <[email protected]> wrote:
> <[email protected]> 于2021年11月9日周二 下午6:52写道： > > > > From: songyutong <[email protected]> > > > > In function vtenc_populate_extradata(), there is a manually created > > pixel buffer that has not been released. So we should use > CVPixelBufferRelease > > to release this pixel buffer at the end, otherwise will cause a memory > leak. > Good catch. Pushed. In the future, add your signoff to the commit message once you have self-reviewed and tested the code. (--signoff with the git CLI). > --- > > libavcodec/videotoolboxenc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > > index 8a02d3d1a0..c06b506cc9 100644 > > --- a/libavcodec/videotoolboxenc.c > > +++ b/libavcodec/videotoolboxenc.c > > @@ -2548,6 +2548,7 @@ static int > vtenc_populate_extradata(AVCodecContext *avctx, > > > > > > pe_cleanup: > > + CVPixelBufferRelease(pix_buf); > > if(vtctx->session) > > CFRelease(vtctx->session); > > > > -- > > 2.30.0 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > [email protected] > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > [email protected] with subject "unsubscribe". > > > Test ok here, but I'm not the maintainer of this module. :D > > > Thanks > Steven > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
