After a brief discussion with Michael on IRC, this seems to be the idea of a
path forward that was agreed upon.
1. AVIOContext::written was supposed to be a private field [1], so move the
value utilized internally to FFIOContext, and set the AVIOContext value
from there.
2. Introduce public AVIOContext::bytes_{read,written} statistics fields.
3. Deprecate AVIOContext::written.
I was not sure whether deprecation or straight-out removal was the right thing
to do - since while the field was meant to be internal it was not marked as
such in FFmpeg's merged state of the struct (which is why it did not get
cleaned up into FFIOContext earlier) - but in order to not get stuck on that,
I am now posting this with the full deprecation changes. This way (hopefully)
this change will get more eyeballs and if someone thinks this could just be
removed the patches can be changed to do that instead.
[1]
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=3f75e5116b900f1428aa13041fc7d6301bf1988a
Best regards,
Jan
Jan Ekström (3):
avformat/avio: privatize point of truth for AVIOContext::written
avformat/avio{,buf}: introduce public
AVIOContext::bytes_{read,written}
avformat/avio{,buf}: deprecate AVIOContext::written
doc/APIchanges | 12 ++++++++++++
libavformat/avio.h | 16 ++++++++++++++++
libavformat/avio_internal.h | 5 +++++
libavformat/aviobuf.c | 22 ++++++++++++++++++----
libavformat/version.h | 5 ++++-
5 files changed, 55 insertions(+), 5 deletions(-)
--
2.31.1
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
