Gorilla Maguila <gorilla.maguila <at> gmail.com> writes:
> New patch with some fixes:
Thank you for working on this!
> + if(type != AMF_DATA_TYPE_STRING) {
Please add a space after "if", same below.
> + av_log(NULL, AV_LOG_ERROR, "amfmetadata Expected type 2
Please pass the context to this function and use
it here for the av_log call.
> + return -1;
I suspect AVERROR_INVALIDDATA is more correct.
> + metadata->width = (int)value;
Please remove the ugly casts.
+ }
+ else
+ if
Please put them in one line, same below.
Your patch contains tabs, they cannot be committed to
FFmpeg, you can find them with "tools/patcheck".
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
