On Sat, Sep 25, 2021 at 03:14:34PM +0300, Jan Ekström wrote:
> On Sat, Sep 18, 2021 at 4:27 AM <[email protected]> wrote:
> >
> > From: Limin Wang <[email protected]>
> >
> > Signed-off-by: Limin Wang <[email protected]>
> > ---
>
> Probably something like "avcodec/libsvtav1: fix value range for
> rc_mode" is a bit better as a commit message?
OK, will change that.
>
> > libavcodec/libsvtav1.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index b029e01..509d92d 100644
> > --- a/libavcodec/libsvtav1.c
> > +++ b/libavcodec/libsvtav1.c
> > @@ -522,7 +522,7 @@ static const AVOption options[] = {
> > #undef LEVEL
> >
> > { "rc", "Bit rate control mode", OFFSET(rc_mode),
> > - AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 3, VE , "rc"},
> > + AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 2, VE , "rc"},
>
> And here we have another example of why bare numbers are bad :) .
> Thanks for catching this.
>
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
