Nicolas George:
> Andreas Rheinhardt (12021-08-15):
>> #define OFFSET(x) offsetof(CoreImageContext, x)
>> @@ -663,8 +660,8 @@ const AVFilter ff_vf_coreimage = {
>> .uninit = uninit,
>> .priv_size = sizeof(CoreImageContext),
>> .priv_class = &coreimage_class,
>> - .inputs = vf_coreimage_inputs,
>> - .outputs = vf_coreimage_outputs,
>> + FF_FILTER_INPUTS(vf_coreimage_inputs),
>> + FF_FILTER_OUTPUTS(vf_coreimage_outputs),
>> .query_formats = query_formats,
>> };
>>
>> @@ -685,6 +682,6 @@ const AVFilter ff_vsrc_coreimagesrc = {
>> .priv_size = sizeof(CoreImageContext),
>> .priv_class = &coreimagesrc_class,
>> .inputs = NULL,
>> - .outputs = vsrc_coreimagesrc_outputs,
>> + FF_FILTER_OUTPUTS(vsrc_coreimagesrc_outputs),
>
> In this file, you are using FF_FILTER_INPUTS and FF_FILTER_OUTPUTS
> instead of just FILTER like everywhere else.
>
> I suppose you missed it because it depends on a proprietary operating
> system. I do not mind if you break it, but I suppose other would ;-)
>
> LGTM apart from that.
>
> Regards,
>
Good catch! This file is indeed special: The first version of this
patchset forgot to update it (because I used a sed that involved *.c and
this is the only filter not covered by it). I later found this out (by
checking the few filters that I don't check automatically manually) and
then added the line manually. And botched it.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
